Modify

Ticket #98 (closed task: fixed)

Opened 7 years ago

Last modified 7 years ago

RSS1 Links to Video File Instead of Video_View Page

Reported by: anna Owned by: andycat
Priority: critical Milestone: 0.2
Component: ATEngageVideo Severity:
Keywords: Cc:
Who will test this:

Description (last modified by anna) (diff)

 http://www.engagemedia.org/latestvideos/RSS (OR  http://demo.plumi.org/latestvideos/RSS)

The RSS1 feed links to a video file like this:  http://www.engagemedia.org/Members/plugintv/videos/journey_to_reality.avi

Instead of to a video_view page like this:  http://www.engagemedia.org/Members/plugintv/videos/journey_to_reality.avi/view

I'm trying to make us a Facebook app based on our RSS feeds. As RSS2 isn't working properly I'd like to use the RSS1 feed, but can't so making this a higher priority.

Attachments

Change History

comment:1 Changed 7 years ago by anonymous

It's a problem on demo.plumi.org also see:  http://demo.plumi.org/latestvideos/RSS

comment:2 Changed 7 years ago by and

sorry that latest comment was from me (and), wasn't logged in.

comment:3 Changed 7 years ago by anna

Do we need to either contact qRSS2Syndication maintainers here to ask if this is a general issue:  http://talk.quintagroup.com/

Or do we need to start a branch of the product ourselves?

comment:4 Changed 7 years ago by anonymous

Andy had fixed it previously but I am not sure by what method. Over to you Andy :)

comment:5 Changed 7 years ago by anna

  • Description modified (diff)

here is the fix (which i was in the process of copying over from the other tracker...)

This is the line referring to this link in rss1body in stable: { <link tal:content="item/Identifier"></link> }

This is the line referring to this link in rss1body in testing: { <link tal:content="string: item/Identifier + '/view'"></link> }

PREVIOUS COMMENTS FROM TICKET ON ENGAGEMEDIA.ORG TRACKER

10/17/07 07:31:54 changed by anna

This is the line referring to this link in rss1body in stable: <link tal:content="item/Identifier"></link>

This is the line referring to this link in rss1body in testing: <link tal:content="string: item/Identifier + '/view'"></link>

This suggests to me that this change has been made in testing, but not brought over to stable. If it's ok with Andycat I will commit this change to svn and update in stable.

10/17/07 07:33:52 changed by anna

I checked the latest videos RSS1 feed on testing.engagemedia.org and it appears to be empty:  http://testing.engagemedia.org/latestvideos/RSS

Perhaps there is an error here? Should check before considering moving over to live stable instance.

10/17/07 20:05:22 changed by and

hmmm I thought that had already been fixed  http://trac.engagemedia.org/projects/ticket/494

in the interests of getting through 0.8 I'm pushing this to high priority on 0.9.

comment:6 Changed 7 years ago by anna

  • Priority changed from major to critical
  • Milestone set to 0.2

also looks like this issue had been addressed here:  http://trac.engagemedia.org/projects/ticket/95

and more recently here:  http://trac.engagemedia.org/projects/ticket/328

and a related ticket about moving customisations to RSS into ATVideo product here:  http://trac.engagemedia.org/projects/ticket/206

comment:7 Changed 7 years ago by anna

posted a question on product forum here:  http://talk.quintagroup.com/forums/plone-rss2/618228336

comment:8 Changed 7 years ago by andycat

and the answer is :

The default behaviour for content types is that the url with their id points straight to the default view template

Only ATFile (and everything that derives from it, like ATEngageVideo) changes that behaviour - a url just using the id , rather than a "/name-of-view" appended to it - starts a download of the file.

comment:9 Changed 7 years ago by andycat

You should also know that rss 1 feeds arent being generated by qRSS2Syndication product anyway. That is only doing RSS2 feeds - which are correct but slow..b/c of the unpickling.

So..the real problem is:

The RSS1 has "changed" because at some point the ContentLicencing? product was incorporated into the mix, and overrides the templates of RSS1, using browser views style (zope3) . This applies only to content types that implment Products.ContentLicensing.DublinCoreExtensions?.interfaces.ILicensable which is setup in ContentLicensing/DublinCoreExtensions?/configure.zcml

Compare the source of the RSS1 files:  http://demo.plumi.org/Members/espiBlog/videos/RSS

noting that is an ATFolder type , to :

 http://demo.plumi.org/latestvideos/RSS which is a smart folder

That is, smart folders only have this problem, that is , the std plone rss1 markup - other types of listings based on real folders , have the correct ContentLicensing enhanched + our patch to add 'view' on them

comment:10 Changed 7 years ago by andycat

See here for an example of the correct RSS1 feed -  http://demo.plumi.org/Members/andenator/videos/RSS

with actual CC licences and keywords included.

comment:11 Changed 7 years ago by andycat

The fix is

andy@redfern:~/testing/Products/ATVideo$ svn diff browser/configure.zcml 
Index: browser/configure.zcml
===================================================================
--- browser/configure.zcml      (revision 51178)
+++ browser/configure.zcml      (working copy)
@@ -1,8 +1,11 @@
 <configure xmlns="http://namespaces.zope.org/browser"
            xmlns:five="http://namespaces.zope.org/five"
            xmlns:i18n="http://namespaces.zope.org/i18n"
-           i18n_domain="ContentLicensing">
+          xmlns:zope="http://namespaces.zope.org/zope"
+           i18n_domain="ContentLicensing"> 
 
+  <include package="zope.app.annotation" />
+
   <page
           name="RSS"
       for="Products.ContentLicensing.DublinCoreExtensions.interfaces.ILicensable"
@@ -32,6 +35,13 @@
       allowed_interface="Products.CMFPlone.browser.interfaces.IRecentPortlet"
       />
 
+  <zope:content class="Products.ATContentTypes.content.topic.ATTopic">
+    <implements interface="Products.ContentLicensing.DublinCoreExtensions.interfaces.ILicensable
+                           zope.app.annotation.interfaces.IAttributeAnnotatable"
+      />
+  </zope:content>
 
+
+
 </configure>
 

which will go into SVN soon.

See here on testing

 http://testing.engagemedia.org/latestvideos/RSS  http://testing.engagemedia.org/news_and_events/RSS

RSS2 is still correct - and still slow.

It would be good to do a review of all the syndication links - both RSS1 and RSS2.

comment:13 Changed 7 years ago by andycat

  • Status changed from new to closed
  • Resolution set to fixed

This is done , and checked in SVN

deployed on testing.plumi.org

The code needed for this is summarised in the latest plumi-0.2-rc1 tags on ATVideo/ATMediaFile/PlumiSkin

comment:14 Changed 7 years ago by anonymous

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.