Modify

Ticket #643 (closed task: duplicate)

Opened 3 years ago

Last modified 2 years ago

Add div to iframe for link back to original video

Reported by: and Owned by:
Priority: major Milestone: 4.4 .Beta - Video Publishing
Component: Architecture Severity:
Keywords: Cc:
Who will test this: And

Description

Add a small piece of text in the bottom right below the player - "View original at SiteName?".

(Have spoken with Dimo about this)

Attachments

iframe-screen.jpg Download (59.7 KB) - added by and 3 years ago.

Change History

comment:1 Changed 3 years ago by mike

  • Status changed from new to closed
  • Resolution set to ready for testing

done, you can test it on staging

Changed 3 years ago by and

comment:2 Changed 3 years ago by and

Hey Mike, I get a scroll bar on the right hand side (see screenshot) http://plumi.org/attachment/ticket/643/iframe-screen.jpg

I also think we should make the text about 1/2 that size, not too intrusive.

comment:3 Changed 3 years ago by and

Also clicking the link make you open the page inside that iframe, where as it should be a new tab/page.

comment:4 Changed 3 years ago by mike

ok I've updated staging. The font is now smaller, and the link opens to a new page. Also embedding a video with the updated embedded code should take care of the scrollbar. Unfortunately that means that videos embedded with the old code must be re-embedded (or the iframe height changed from 300px to 320px) with the new embed code or they will contain scrollbars. That is because the old iframe code had the exact flowplayer size.

comment:5 Changed 3 years ago by and

So just to confirm that means that they have to go back to the size and re-embed it? In that sense hundreds of videos that are already embedded would get that horrible scroll bar?

If that's the case I think it's better to scrap the idea, I think it will annoy a lot of people. Is there anyone around it?

comment:6 Changed 3 years ago by mike

Unfortunattely, I can't find any consistent way of changing this without probably messing up with the page that the iframe is embedded on. I'm rolling back the changes. If Dimo or someone else comes up with a better idea on how to deal with this, we can take another go.

comment:7 Changed 3 years ago by and

OK. Would one idea be to put the new player in a different place so that the old code still worked but every new one contained this bit of code? If that makes sense :)

comment:8 Changed 3 years ago by and

  • Status changed from closed to reopened
  • Resolution ready for testing deleted
  • Milestone changed from 4.2 RC 1 & Update of EM Staging to 4.3 Beta1

comment:9 Changed 3 years ago by dimo

  • Milestone changed from 4.3 Beta1 to 4.4 Beta (Language Related New Features and Fixes)

comment:10 Changed 3 years ago by anna

  • Milestone changed from 4.6 Beta (Language Related New Features and Fixes) to 4.4 EM Re-Design

comment:11 Changed 2 years ago by anna

  • Status changed from reopened to closed
  • Resolution set to duplicate
View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.