Modify

Ticket #588 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

4.0 Design Bugs

Reported by: anna Owned by:
Priority: major Milestone: 4.1 Beta 1 (New Features and Fixes)
Component: DesignCSS Severity:
Keywords: Cc:
Who will test this: And

Description (last modified by anna) (diff)

Some 4.0 design bugs that have either re-appeared on demo (but not testing - why would this be?) or that are also on testing.

  • Double borders around content area (middle column) on front page when logged in (only on demo not testing)

 http://demo.plumi.org/

  • Borders missing on outside of portlets in right and left columns (demo & testing)

 http://demo.plumi.org/  http://testing.plumi.org/

  • Login fields out of alignment (demo only)

 http://demo.plumi.org/login_form

  • Comment text over author thumbnail in comments (demo only)

 http://demo.plumi.org/Members/andenator/videos/itravellp.mp4/view  http://testing.plumi.org/Members/anna/videos/test-video/view

Attachments

Change History

comment:1 Changed 3 years ago by anna

  • Component changed from Architecture to DesignCSS

comment:2 Changed 3 years ago by anna

  • Description modified (diff)

comment:3 Changed 3 years ago by mike

  • Status changed from new to closed
  • Resolution set to ready for testing

The 1st and 3rd issues are fixed now (it was my bad in updating demo).

The 2nd issue I think is what is supposed to happen because I see the left/right border disabled specifically in plumi.css. It's an easy fix if we want them back and can go into plumi 4.1 if you prefer it that way.

The last issue is a plone.app.discussion issue that was fixed on RC1 release 3 days ago (which is used on testing, but was pinned to beta12 for plumi 4 release). It should be fixed automatically when we update demo to 4.1.

comment:4 Changed 3 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

cool on 1st/3rd issue

and 4th issue - cool, good to know.

2nd issue - ah, i hadn't realised that - not sure why they would have been, looks odd to me! i think we should re-instate them. will tick this off when they are back in, thx for that.

comment:5 Changed 3 years ago by mike

  • Status changed from reopened to closed
  • Resolution set to ready for testing

Fixed the borders in testing.

comment:6 Changed 3 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

 http://testing.plumi.org/

Video listings:

Categories shows even when there have been none added

Countries - shows "----------" in listings.

Borders look good - except actually there is a double line at the bottom of portlets in the left column - can we remove this, make it a single border as per the other portlets?

comment:7 Changed 3 years ago by anna

Callouts show on front page in Safari but not in Firefox:  http://testing.plumi.org/

comment:8 Changed 3 years ago by anna

Shaded background shows on title of TagCloud? & Log In portlets - but not in other portlets. Should be removed from these two portlets to be consistent.

 http://testing.plumi.org/

comment:9 Changed 3 years ago by mike

portlet header background and double bottom border removed (testing).

comment:10 Changed 3 years ago by anna

Callouts no longer showing in Safari. Also portlet header background and border tested (done).

Only this left:

 http://testing.plumi.org/

Video listings:

Categories shows even when there have been none added

Countries - shows "----------" in listings.

comment:11 Changed 3 years ago by mike

About the Callouts issue: There are actually two issues:

a) catalog will not return expired callouts when logged out.

b) the featured callout section would show expired callouts (when logged in due to a).

I've fixed b) and callouts never appear on front page when they are expired. We first search through the catalog for the list of featured callouts, sorted on effective date (date of first publication). Then we return the first non-expired callout.

comment:12 Changed 3 years ago by mike

Correction: plone only returns the expired callouts when logged in as manager.

comment:13 Changed 3 years ago by mike

Fixed on testing and staging. I added the fix to the plumi installation and also added the creation of the past callouts collection to it.

comment:14 Changed 3 years ago by mike

  • Status changed from reopened to closed
  • Resolution set to ready for testing

comment:15 Changed 3 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

comment:16 Changed 3 years ago by anna

  • Status changed from reopened to closed
  • Resolution set to fixed

fixed

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.