Modify

Ticket #476 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

Add you FB/twitter/other social networking spaces to your profile

Reported by: and Owned by: dave
Priority: major Milestone: 4.3 Beta1
Component: AuthorProfile Severity:
Keywords: Cc:
Who will test this: And

Description (last modified by anna) (diff)

Create fields for three URLs listed in the author page - with logic to display icons for the major social networking sites - MySpace?, Facebook, Twitter and Kaskus.

Otherwise people can add other sites like their vimeo or youtube channel or blogs etc...

Attachments

Screenshot-authorpage-1.png Download (20.2 KB) - added by dave 4 years ago.
Davo probably mistakes what the ticket was requesting …
Screenshot-authorpage-2.png Download (22.1 KB) - added by dave 4 years ago.
Messy messy ... this should be done cleaner again, url2, url3, url4 is not a good way to solve this properly

Change History

comment:1 Changed 4 years ago by anna

  • Description modified (diff)

comment:2 Changed 4 years ago by anna

  • Milestone changed from 4.1 Beta 1 to 4.1 Beta 2

comment:3 Changed 4 years ago by anna

  • Owner set to dave

comment:4 Changed 4 years ago by dave

Hiya, I actually did this, then went to report on the ticket and realised it was not probably what you are after ...

Am I correct in re-reading the above ticket that you want 3 'open' fields for any type of url, that _detects_ if the url placed in the field is one of those you listed and shows some sort of icon?

If so, I will need to have an idea how this is to be laid out in regard graphics/icon.

See attached image as to what I did, adding specific fields to the memberdata for the sites you listed, and was going to ask about icons (imagery) for them. I am now thinking I was totally on the wrong track.

Changed 4 years ago by dave

Davo probably mistakes what the ticket was requesting …

comment:5 Changed 4 years ago by dave

Looking at trying to add a lines field to the author page to add more urls (limiting to 3 more) .. I could just add url2, url3, url4 properties, but this seems messy after coding it. A cleaner way would be to have an option 'add another' opening another text field and storing it in a list/lines format.. datagridfield seems like the go, but not sure the best way to implement it.

talked to some folk on #plone and pointed at

 http://svn.plone.org/svn/collective/collective.examples.userdata/trunk/README.txt

So will move forward with that methodology

Changed 4 years ago by dave

Messy messy ... this should be done cleaner again, url2, url3, url4 is not a good way to solve this properly

comment:6 Changed 4 years ago by dave

I have committed changes to the repository, I have followed what unweb has done with adding custom data to the memberdata, however the graphical layout needs work as in regard how these lists of homepages display.

To do the 'logic to display icons' I need some direction as to the layout for display.

comment:7 Changed 4 years ago by mike

Hi Dave,

can you create a '4.1' or a 'dave' branch and commit your changes there? Trunk is used for development of Plumi 4.0 and we're about to release a final, stable version. Once we publish plumi 4 in the following days, we'll merge the 4.1 or dave branch with trunk and continue working there.

thanks

comment:8 Changed 4 years ago by dave

updated with the icons etc in branch/dave and on testing server atm

comment:9 Changed 4 years ago by dave

  • Status changed from new to closed
  • Resolution set to ready for testing

comment:10 Changed 4 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

This looks good. My only question now is how should the existing URL field relate to these other URLs?

My suggestion is this - that rather than calling them "Homepages" we call them "Social Networks and Blogs" and have the sign-post text as "Connect with me via social networks, or read my blog posts"

Then on the author page you could separate this out from the existing URL, by giving it a heading called "Website" and then having a bit of space, and then having a heading called "Social Networking and Blogs" and those URLs listed below.

We might come up with some more interesting ways to display that info later, but this is my suggestion to tweak what you've already done.

Let me know what you all think about this. You can try it out at the moment at  http://testing.plumi.org:16080/Plone/personalize_form

Alternatively, could we merge the URL fields together, and just have one UI heading called "Websites and Social Networking: enter URLs for your websites, blogs and social networks such as Facebook and Twitter".

comment:11 Changed 4 years ago by anna

(it was calling them both "homepages" that was especially confusing, but it does raise other questions about the UI)

comment:12 Changed 4 years ago by dave

  • Status changed from reopened to closed
  • Resolution set to ready for testing

I've done a merge of a few things there, it's a little confusing over which is for the personalize form and the author page

comment:13 Changed 4 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

whoa - this should not have been merged - this needs reverting immediately. this ticket was not finished, nor declared fixed. questions still remain

this is now live on the production em.org site and causing errors.

comment:14 Changed 4 years ago by anna

 http://www.engagemedia.org/personalize_form

We’re sorry, but there seems to be an error…

Here is the full error message:

Display traceback as text

Traceback (innermost last):

  • Module ZPublisher.Publish, line 127, in publish
  • Module ZPublisher.mapply, line 77, in mapply
  • Module ZPublisher.Publish, line 47, in call_object
  • Module Products.CMFFormController.FSControllerPageTemplate, line 91, in call
  • Module Products.CMFFormController.BaseControllerPageTemplate?, line 28, in _call
  • Module Products.CMFFormController.ControllerBase?, line 231, in getNext
  • Module Products.CMFFormController.Actions.TraverseTo?, line 38, in call
  • Module ZPublisher.mapply, line 77, in mapply
  • Module ZPublisher.Publish, line 47, in call_object
  • Module Products.CMFFormController.FSControllerPythonScript, line 105, in call
  • Module Products.CMFFormController.Script, line 145, in call
  • Module Products.CMFCore.FSPythonScript, line 130, in call
  • Module Shared.DC.Scripts.Bindings, line 324, in call
  • Module Shared.DC.Scripts.Bindings, line 361, in _bindAndExec
  • Module Products.PythonScripts?.PythonScript?, line 344, in _exec
  • Module script, line 6, in personalize <FSControllerPythonScript at /plumi/personalize> Line 6
  • Module <string>, line 6, in setProperties
  • Module plone.protect.utils, line 43, in _curried
  • Module Products.CMFPlone.patches.csrf, line 34, in setProperties
  • Module Products.CMFCore.MemberDataTool?, line 296, in setProperties
  • Module Products.PlonePAS.tools.memberdata, line 261, in setMemberProperties
  • Module Products.PlonePAS.sheet, line 75, in setProperty
  • Module Products.PlonePAS.sheet, line 72, in validateProperty

PropertyValueError?: Invalid value (twitter.com/engagemedia) for property 'homepages' of type lines

comment:15 Changed 4 years ago by dave

  • Status changed from reopened to closed
  • Resolution set to ready for testing

I presume this added issue is resolved (there was a commit that was not rolled back correctly on my part that was pushed to EM) so placing the ticket back into ready for testing so it is not overlooked.

comment:16 Changed 4 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

Ttesting this here:  http://testing.plumi.org:16080/Plone/author/test

Ah, not quite what I meant in terms of labelling on the view of author page - what I meant was - label the "URL" as "Website" and then below that have "Social Networking and Blogs".

(currently it says URL:http://www.example.com, and then below that says Website, and then below that says Social Networking and Blogs. so take out the "URL" part, calling that "Website" instead)

Very close though! Works well otherwise.

comment:17 Changed 4 years ago by dave

  • Status changed from reopened to closed
  • Resolution set to ready for testing

comment:18 Changed 4 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

Brilliant, done.

comment:19 Changed 4 years ago by anna

  • Status changed from reopened to closed
  • Resolution set to to merge

comment:20 Changed 4 years ago by anna

  • Status changed from closed to reopened
  • Resolution to merge deleted

This is available in the edit form, but not in the author page on testing or on Dave's testing site:  http://testing.plumi.org/author/anna  http://testing.plumi.org:16080/Plone/author/manager

comment:21 Changed 4 years ago by dave

  • Status changed from reopened to closed
  • Resolution set to ready for testing

This was restored, I am presuming somethings got lost in the merge of the branch, as it is in the branch, but was not in trunk

 http://testing.plumi.org:16080/Plone/author/manager

comment:22 Changed 4 years ago by anna

  • Status changed from closed to reopened
  • Resolution ready for testing deleted

re-tested this - ready to go, please put this in 4.1 release

comment:23 Changed 4 years ago by anna

  • Status changed from reopened to closed
  • Resolution set to fixed
View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.