Modify

Ticket #220 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove Line Break from Indytube template - <object> tag

Reported by: anna Owned by: andycat
Priority: critical Milestone: 0.3alpha - Plumi to Plone 3
Component: EmbeddedPlayback Severity:
Keywords: Cc:
Who will test this:

Description

specifically, this http://plumi.org/browser/indytube/tags/plumi-0.2.3-rc3/plumi.template has a line break in the middle of the first <object ... > tag which doesnt make a different in HTML at all. Thats how and why the embedded HTML working on our site. (which pulls in the flowplayer SWF, but that is an independent layer above this, and not related to this problem at all, it could easy pull in a SWF movie that is a online gambling game etc etc).

This same HTML code, when pasted into other websites, I suspect, especially blogging software, is making line break -> "<br/>" conversions and hence fucking up the HTML.

Ive removed the line break , from our _production copy_ on cwood, of indytube's template. Nothing has been done in SVN. specifically, this andy@collingwood:/opt/EngageMediaPlumiProducts/indytube$ vi plumi.template

which is where indytube is running from, and the template we are using.

So this fix is deployed onto our live site, ie no more line breaks in the middle of the first <object ..> tag, or any tags for that matter.

Attachments

Change History

comment:1 Changed 5 years ago by andycat

  • Status changed from new to closed
  • Resolution set to fixed

fixed http://plumi.org/changeset/892/ on branch 'plumi-0.2.x' of indytube

updated plumi trunk (which is included in plumi-buildout-plone3) to include this branch, instead of a tag.  http://dev.plone.org/collective/changeset/85105

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.